Add important asserts to the default save inventory #15197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose a fixed_foreign_keys list, givin us a way to assert referential integrity. This tool is vital for targeted refresh where we need to be sure, that the referential integrity will not be broken.
Extract distinct relation assertion to a base class
Extract referential integrity assertion to a base class
Use base class assert_distinct_relation
USe base class assert_referential_integrity
|
@miq-bot add_label enhancement |
|
Checked commits Ladas/manageiq@4c99c65~...bcab13b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/models/manager_refresh/inventory_collection.rb
app/models/manager_refresh/save_collection/saver/base.rb
|
|
@agrare can we ignore the 'Use next to skip iteration' I want to do return there if the first breaks the assert. Rubocop got it wrong I think :-) And I am fixing the other in next PR |
Yeah agreed that looks fine to me |
agrare
approved these changes
May 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add important asserts to the default save inventory. First we just extract the distinct assert to a base class. Then we are adding an assert for a referential_integrity.